• Andreas Haas's avatar
    [wasm] Resolve promise in separate task · f8362a95
    Andreas Haas authored
    With recent changes, we resolve the promise of e.g. WebAssembly.compile
    with the external API, and not the V8-internal API. The external API,
    however, also handles microtasks, and depending on the MicrotasksPolicy,
    may also execute microtasks immediately. This means the then-handler of
    WebAssembly.compile may get executed within all the scopes that were
    open when the external API was called. One of the open scopes is the
    CancelableTask that finishes WebAssembly compilation.
    
    The deadlock seen in the issue arises now when {quit()} gets called in
    the then-handler of WebAssembly compilation.  The reason is that
    {quit()} terminates the isolate, and during isolate termination, we wait
    for all running CancelableTasks to finish. This, however, means a
    deadlock, because the task that terminates the isolate is waiting for
    itself to finish.
    
    R=jkummerow@chrommium.org
    
    Bug: chromium:1338150
    Change-Id: I89243daffc76a456293519e24bfaad88277bb99a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717990Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81311}
    f8362a95
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...