• Andreas Haas's avatar
    [wasm] Resolve promise in separate task · f8362a95
    Andreas Haas authored
    With recent changes, we resolve the promise of e.g. WebAssembly.compile
    with the external API, and not the V8-internal API. The external API,
    however, also handles microtasks, and depending on the MicrotasksPolicy,
    may also execute microtasks immediately. This means the then-handler of
    WebAssembly.compile may get executed within all the scopes that were
    open when the external API was called. One of the open scopes is the
    CancelableTask that finishes WebAssembly compilation.
    
    The deadlock seen in the issue arises now when {quit()} gets called in
    the then-handler of WebAssembly compilation.  The reason is that
    {quit()} terminates the isolate, and during isolate termination, we wait
    for all running CancelableTasks to finish. This, however, means a
    deadlock, because the task that terminates the isolate is waiting for
    itself to finish.
    
    R=jkummerow@chrommium.org
    
    Bug: chromium:1338150
    Change-Id: I89243daffc76a456293519e24bfaad88277bb99a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717990Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81311}
    f8362a95
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...