• Clemens Hammacher's avatar
    [handles] Use is_convertible instead of is_base_of · f8072dbd
    Clemens Hammacher authored
    std::is_base_of<A, B> has undefined behaviour if B is not a complete
    type. Hence, avoid it and use is_convertible<B*, A*> instead.
    This captures exactly the requirement that
      Handle<A> foo() { return produce<Handle<B>>(); }
    is valid exactly if
      A* foo() { return produce<B>(); }
    is valid.
    Also, change some static asserts to enable_ifs in order to allow
    overloading a function by different Handle types, which would cause
    disambiguity otherwise.
    
    R=tebbi@chromium.org
    
    Change-Id: I60fbdfcfd96c7b216e42819a5b5de3423a2c38d0
    Reviewed-on: https://chromium-review.googlesource.com/774841Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49440}
    f8072dbd
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...