• caitpotter88's avatar
    [destructuring] don't attempt to visit contents of FunctionLiterals · f60048c5
    caitpotter88 authored
    The parser eagerly rewrites destructuring assignments occuring
    in formal parameter initializers, because not doing so would
    cause the BindingPattern rewriting to be confused and do the
    wrong thing.
    
    This change prevents this rewriting from descending into the
    bodies of lazily parsed functions.
    
    In general, it's a mistake to descend into the bodies of function
    literals anyways, since they are rewritten separately on their
    own time, so there is no distinction made between lazily
    "throw away" eagerly parsed functions in the temporary parser
    arena, or "real" eagerly parsed functions that will be compiled.
    
    BUG=chromium:594084, v8:811
    LOG=N
    R=adamk@chromium.org, littledan@chromium.org
    
    Review URL: https://codereview.chromium.org/1864553002
    
    Cr-Commit-Position: refs/heads/master@{#35277}
    f60048c5
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...