• Andreas Haas's avatar
    [wasm] Delay error messages for lazy compilation · fe53fbfc
    Andreas Haas authored
    With streaming compilation we delay the generation of errors until after
    all bytes are received, so that potentially better error messages get
    generated. With this CL we also delay the generation of errors in the
    combination of lazy compilation and streaming compilation.
    
    In particular, this CL does the following:
    * It avoids the creation of a `DecodeFail` task in
    `FinishAsyncCompileJobWithError`, which would create an error immediately before a potential name section arrived.
    * It calls `CompilationStateImpl::SetError()` so that an error is
    created once the stream finishes.
    * It removes the return value of `ProcessFunctionBody` so that wire
    bytes continue to be received even after a validation error.
    * It adds an early exit to `ProcessFunctionBody` if
    `CompilationStateImpl::failed()` is true, so that we don't continue
    validation after the first detected error.
    
    R=clemensb@chromium.org
    
    Bug: v8:12852
    Change-Id: Ie8c6be243a257ef62cbb29fea6b8e0c205060680
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3802691Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82181}
    fe53fbfc
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
flags Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
js-atomics Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
tracing Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
avoid-windows-h-includes.cc Loading commit data...
gay-fixed.cc Loading commit data...
gay-fixed.h Loading commit data...
gay-precision.cc Loading commit data...
gay-precision.h Loading commit data...
gay-shortest.cc Loading commit data...
gay-shortest.h Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...