• Ng Zhi An's avatar
    [wasm-simd] Fix f64x2 replace lane · f3cbcdb2
    Ng Zhi An authored
    There are a couple of bugs here:
    
    1. The immediate used for vinsertps is wrong when lane == 1, the first
    two bits specify which element of the source is copied, and it should
    always be 00, 01 to copy the first 2 lanes of source.
    2. For both cases, the second insertps call should be using dst as the
    src, since dst was already updated by the first insertps call, it was
    incorrectly using the old value of src. This was probably working
    correctly because in many cases dst and src happened to be the same
    register.
    3. rep cannot be same as dst, because dst is overwritten, and rep should
    stay the same
    
    I also modified the F64x2ReplaceLane to test separately for replacing
    lane 0 and lane 1.
    
    Fixed bug 3. for arm and arm64.
    
    Bug: v8:9728
    Change-Id: Iec6e48bcfbc7d27908dd86d5f113a8b5dedd499b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1877055Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64620}
    f3cbcdb2
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...