• Clemens Backes's avatar
    [liftoff] Speed up check for debug info · f38e4093
    Clemens Backes authored
    The {NextInstruction} method is quite hot, since it's called for every
    since Wasm instruction. It currently does several checks to figure out
    if
    - a breakpoint needs to be emitted,
    - extra source positions are needed, or
    - tracing is active.
    
    The first two can only happen if we are generating debug code, hence
    check for that first. The last can only happen in debug mode, so it's
    not an issue in production.
    
    Finally, outline the emission of debug information. This leads to
    inlining of the {NextInstruction} method into callers, where it is a
    single check followed by a call to {EmitDebuggingInfo} (in release
    mode).
    
    R=thibaudm@chromium.org
    
    Bug: v8:10576
    Change-Id: I5047406f55cd14c6c639528ef6e3422af27d16b1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249671
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68399}
    f38e4093
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...