• littledan's avatar
    Make test262 test runner check for which exception is thrown · f3568ca4
    littledan authored
    test262 "negative" test expectations list which exception is thrown. The ES2017
    draft specification is very specific about which exception class is thrown
    from which path, and V8 works hard to be correct with respect to that spec.
    
    Previously, the test262 test runner would accept any nonzero status code,
    such as from a crash, or a FAIL printed out, for a negative test. This
    patch makes negative tests check for the right answer using a quick-and-dirty
    parsing of the exception printing from d8 to find the exception class.
    It invokes d8 in a way to get a status code of 0 from thrown exceptions
    so that 'negative' tests aren't actually implemented by negating the output.
    
    Amazingly, this didn't catch any test262 failures, but I verified the extra
    checking interactively by changing a negative test to expect a different type
    and saw it fail.
    
    BUG=v8:4803
    R=machenbach
    LOG=Y
    
    Review URL: https://codereview.chromium.org/1766503002
    
    Cr-Commit-Position: refs/heads/master@{#34763}
    f3568ca4
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...