• Simon Zünd's avatar
    [debug] Immediately step-in for 'stack check triggered' debug breaks · 3297ccca
    Simon Zünd authored
    This CL changes debug breaks that are triggered via interrupts (i.e.
    via stack check). One client of this behavior is the `Debugger.pause`
    CDP method.
    
    The problem is that when we pause so early, the JSFunction didn't have
    time yet to create and push it's context. This requires special
    handling in the ScopeIterator and makes an upcoming change unnecessary
    complex.
    
    Another (minor) problem is that local debug-evaluate can't change
    context-allocated local variables (see changed regression bug). Since
    the context is not yet created and pushed, variables are written to
    the DebugEvaluateContext that goes away after the evaluation.
    
    The solution is to mirror what `BreakOnNextFunction` does. Instead
    of staying paused in the middle of the function entry, we trigger
    a "step in" and pause at the first valid breakable position instead.
    This ensures that the function context is already created and pushed.
    
    Note that we do this only in case for JSFunctions. In all other cases
    we keep the existing behavior and stay paused in the entry.
    
    R=jgruber@chromium.org
    
    Fixed: chromium:1246907
    Change-Id: I0cd8ae6e049a3b55bdd44858e769682a1ca47064
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854501Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82817}
    3297ccca
Name
Last commit
Last update
..
wasm/gdb-server Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
debug-coverage.cc Loading commit data...
debug-coverage.h Loading commit data...
debug-evaluate.cc Loading commit data...
debug-evaluate.h Loading commit data...
debug-frames.cc Loading commit data...
debug-frames.h Loading commit data...
debug-interface.cc Loading commit data...
debug-interface.h Loading commit data...
debug-property-iterator.cc Loading commit data...
debug-property-iterator.h Loading commit data...
debug-scope-iterator.cc Loading commit data...
debug-scope-iterator.h Loading commit data...
debug-scopes.cc Loading commit data...
debug-scopes.h Loading commit data...
debug-stack-trace-iterator.cc Loading commit data...
debug-stack-trace-iterator.h Loading commit data...
debug-type-profile.cc Loading commit data...
debug-type-profile.h Loading commit data...
debug-wasm-objects-inl.h Loading commit data...
debug-wasm-objects.cc Loading commit data...
debug-wasm-objects.h Loading commit data...
debug-wasm-objects.tq Loading commit data...
debug.cc Loading commit data...
debug.h Loading commit data...
interface-types.h Loading commit data...
liveedit-diff.cc Loading commit data...
liveedit-diff.h Loading commit data...
liveedit.cc Loading commit data...
liveedit.h Loading commit data...