• Joyee Cheung's avatar
    [class] error when accessing unused static private method at debug time · f2fd4923
    Joyee Cheung authored
    At the moment when the static private method is unused
    in source code (either explicitly or through eval) but is accessed
    at runtime through the debugger, and there are no other potential
    references to the class variable in the source code otherwise,
    the reference to the class variable is lost here since the class
    variable would not be context-allocated, then we could not rebuild
    a proper brand check for it.
    
    For now, a ReferenceError would be thrown and the method is considered
    "optimized away", similar to how unused ordinary methods in closures
    work. Before this patch it would DCHECK when generating bytecode
    for the debugger instead of throwing errors.
    
    Bug: v8:9839, v8:8330
    Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66734}
    f2fd4923
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...