• Dominik Inführ's avatar
    [heap] Use base::SharedMutex in Heap::IsPendingAllocation · f2fd431a
    Dominik Inführ authored
    Use a read-write lock for protecting original_top, original_limit and
    pending_object for all spaces. This way Heap::IsPendingAllocation is
    always guaranteed to read a consistent top/limit-pair and also the
    last values for those fields.
    
    The main thread will acquire an exclusive lock to update those fields.
    Concurrent Turbofan threads will use shared locks to read them.
    
    This may be quite expensive on the Turbofan-side, so landing this CL
    should help us figure out how big of a regression this simple fix would
    be. For main thread execution performance is supposed to be okay, since
    this is only used on the allocation slow path.
    
    Bug: v8:11778, chromium:1213266
    Change-Id: I9464f53fd50057ec2540ab5b79f74ee52a5d7500
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903143
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74814}
    f2fd431a
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...