• Santiago Aboy Solanes's avatar
    [compiler] Perform Map::bit_field_3 non-release/acquire if possible · f2b4272d
    Santiago Aboy Solanes authored
    We have to have special rules for bit_fields since we multiple accesors
    touch the same field. I used:
     * If the accessor is set at map initalization time only and:
       * only the main thread accesses it: non-atomic write/read
       * bg accesses it too: non-atomic write, relaxed read (read has to be
         relaxed due to the whole bit_field being modified concurrently via
         other bit_field3 accessors)
     * If the accessor is set after map initialization:
       * but it is not necessary for synchronization: relaxed write/read
       * If the accessor is needed for synchronization: release/acquire
    
    As a note, Map::NumberOfOwnDescriptors are the bits accessed by the
    concurrent marker. For concurrent marker reasons it can be relaxed, but
    we would like it to be release/acquire for the compiler since that's
    where we synchronize Maps with adding descriptors to the descriptor
    array.
    
    Bug: v8:7790, chromium:1150811
    Change-Id: I0ba7d2f8cb81d65a487970b4ea0bfa2a4cb3a975
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773286Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73911}
    f2b4272d
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...