• Marja Hölttä's avatar
    [parser|ast] Simplify AstNodeFactory Zone usage. · f270bbfa
    Marja Hölttä authored
    AstNodeFactory used to get the Zone directly from AstValueFactory. But that's
    generally the wrong Zone (the main Zone, instead of the temp Zone), and the
    creator of AstNodeFactory had to call set_zone right after. By adding a Zone
    param, we can pass the correct Zone right away.
    
    Also made PreParserFactory have an AstNodeFactory, so that we don't need to
    create temporary AstNodeFactories all the time.
    
    Also removed AstNodeFactory::BodyScope since DiscardableZoneScope essentially
    did the same thing already.
    
    BUG=v8:5516,v8:6092
    
    Change-Id: I189d2e6afe91c91e49d8ed7e3496a0d9c405e1c5
    Reviewed-on: https://chromium-review.googlesource.com/507129
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarDaniel Vogelheim <vogelheim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45370}
    f270bbfa
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
DEPS.chromium Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...