• mtrofin's avatar
    [wasm] Fix serialization after instantiation · f2531acb
    mtrofin authored
    The regression comes from attempting to serialize a module with memory
    requirements after instantiation - which is what happens in common emscripten
    scenarios, where the module is obtained from WebAssembly.instantiate(buffer). We then try and serialize the JSArrayBuffer
    representing the instance memory. That operation fails.
    
    Added regression test and also extended the test to cover the other 2
    instance-specific values - globals and tables.
    
    Added a discussion on WasmCompiledModule (comments) explaining design decisions.
    
    BUG=chromium:705562
    
    Review-Url: https://codereview.chromium.org/2784453002
    Cr-Commit-Position: refs/heads/master@{#44250}
    f2531acb
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...