• Benedikt Meurer's avatar
    [inspector] Account for dynamic nature of the `fn.name` property. · f1ddb2fa
    Benedikt Meurer authored
    With https://crrev.com/c/3272577 we introduced a `StackFrame` cache for
    the inspector, which is keyed on the script ID, line and column number,
    so the syntactic properties of the function. However, the name that we
    report for functions is dynamic and can change (per closure) by
    explicitly reconfiguring the "name" property via
    
    ```js
    var f = function() { /* ... */ }
    Object.defineProperty(f, "name", {value: "super duper function"});
    ```
    
    for example, so we need to take that into account as well, and only use
    the cached `StackFrame` instance if the dynamic names still match up.
    Otherwise we just overwrite the cached entry with a new instance (the
    assumption here is that "name" isn't reconfigured often).
    
    Fixed: chromium:1274529
    Bug: chromium:1268436
    Change-Id: I519017c762aed5b4f93b9dc4553fa81d5979f1a1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306376
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78127}
    f1ddb2fa
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
security Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...