• Adam Klein's avatar
    [parser] More carefully handle destructuring in arrow params · f1a55180
    Adam Klein authored
    This patch attempts to reduce the special handling of destructuring
    assignments in arrow function parameters by "adopting" them from
    wherever they were initially parsed into the arrow function's
    FunctionState/Scope. This avoids incorrectly re-setting the
    Scope of such assignments multiple times for arrow functions
    that are nested inside other arrow params themselves.
    
    It also generally seems better, in that we now only rewrite
    destructuring assignments for a single function at a time.
    
    Bug: chromium:807096
    Change-Id: I6bef5613f99e3e8c130fc0aa2ee5d6fcf2efd34b
    Reviewed-on: https://chromium-review.googlesource.com/900168Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarCaitlin Potter <caitp@igalia.com>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51155}
    f1a55180
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...