• Dan Elphick's avatar
    [compiler] Don't collect source positions when throwing exceptions · f12e8d64
    Dan Elphick authored
    While crrev.com/c/1520721 tried to avoid collecting source positions
    when throw exceptions, it failed because they were still collected in
    Isolate::CaptureStackTrace.
    
    This removes that collection point and lets SetStackFrameCacheCommon
    bail out when trying to set the stack frame cache for a bytecode that
    doesn't have source positions.
    
    It also adds tests that ensure source positions are not collected when
    an exception is thrown (although one is disabled as it does not yet
    work).
    
    Bug: v8:8510
    Change-Id: Id5caf579dda549d637fa9b3129c419d524be5ff2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565898
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60847}
    f12e8d64
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...