• verwaest's avatar
    Revert of Always deserialize scope infos for parsing (patchset #3 id:40001 of... · f046cb95
    verwaest authored
    Revert of Always deserialize scope infos for parsing (patchset #3 id:40001 of https://codereview.chromium.org/2280933002/ )
    
    Reason for revert:
    Significantly tanks parsing. We probably should just keep on doing what we're doing: partially deserialize while resolving variables. If we do scope-info backed resolution after regular resolution based on remaining free variables, we can probably reduce the time-frame of that part. We soon after anyway need to sync with the main thread.
    
    Original issue's description:
    > Always deserialize scope infos for parsing
    >
    > When looking up variables in the ScopeInfo, we did a linear scan of the
    > ScopeInfo. Since that's unacceptably slow, a context slot cache was added
    > that would speed up repeated lookups of the same variable.
    >
    > Instead, just always fully convert the ScopeInfo into scopes, so they can
    > lookup variables without scanning the ScopeInfo.
    >
    > This also allows for removing the now unused ContextSlotCache.
    >
    > R=adamk@chromium.org,verwaest@chromium.org,marja@chromium.org
    > BUG=v8:5315
    >
    > Committed: https://crrev.com/81f824cad18e4dc873a8838943217eb9c9f0c1f0
    > Cr-Commit-Position: refs/heads/master@{#38953}
    
    TBR=adamk@chromium.org,marja@chromium.org,jochen@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:5315
    
    Review-Url: https://codereview.chromium.org/2287783003
    Cr-Commit-Position: refs/heads/master@{#38958}
    f046cb95
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...