• Leszek Swirski's avatar
    [CSA] Allow Assert to print variables · eff31fd1
    Leszek Swirski authored
    Allow appending expressions to a CSA_ASSERT call, which will be printed
    if the assert fails, e.g.
    
        CSA_ASSERT(csa, IsFixedArray(array), array)
     ->
        CSA_ASSERT failed: IsFixedArray(array) [../../src/foo.cc]
         * array: 0x12345678 <SharedFunctionInfo>
    
    This helps debug assert failures where it may not be immediately obvious
    why the assert failed, and the runtime call to print the failure has
    already clobbered the registers used by the predicate.
    
    Currently, the number of additional expressions is limited to 5, for
    macro simplicity.
    
    Change-Id: I000b6806ea0f8f9240493b3606c9f845ca65faf9
    Reviewed-on: https://chromium-review.googlesource.com/584752
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46878}
    eff31fd1
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...