• Jakob Gruber's avatar
    Reland "[compiler] Emit a function-entry stack check on OSR-entry" · efccaebe
    Jakob Gruber authored
    This is a reland of 8703c38d
    
    The reland marks the new test as slow, skips all variants, and
    skips all non-release modes.
    
    Original change's description:
    > [compiler] Emit a function-entry stack check on OSR-entry
    >
    > This CL extends the smarter function-entry stack check logic (see
    > v8:9534) to OSR'd code. These smarter stack checks prevent
    > overflowing the stack during deoptimization.
    >
    > The challenge for both function-entry (FE) and OSR-entry (OE) stack
    > checks is that there is no dedicated physical StackCheck to
    > deoptimize into. For more context: the physical StackCheck bytecode
    > was removed in crrev.com/c/1914218.
    >
    > FE stack checks solve this by using a marker bailout id to signify
    > a deopt bytecode offset before the first bytecode.
    >
    > In this CL, OE stack checks take a similar approach by using the
    > OSR'd loop's JumpLoop bytecode, which is conceptually immediately
    > before the OSR'd loop header.
    >
    > When a stack overflow at an OE stack check occurs: %StackGuard
    > may cause a lazy deopt on return to the optimized OSR code,
    > causing re-execution of the JumpLoop handler in the
    > InterpreterEnterBytecodeAdvance builtin, ultimately continuing
    > execution the interpreter at the first bytecode of the OSR'd loop
    > header.
    >
    > Bug: chromium:1034322, v8:9534
    > Change-Id: I1ae88a08702cde9a5eb84a451a9f1acc41204d5c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2625872
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#72153}
    
    Tbr: neis@chromium.org, solanes@chromium.org
    Bug: chromium:1034322
    Bug: v8:9534
    Change-Id: I28a23d0cc4b14d59c3d4a5dbadd5dab3ac31d442
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2639753Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72183}
    efccaebe
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...