• Clemens Hammacher's avatar
    [wasm] Fix code space management · eeb15e84
    Clemens Hammacher authored
    On windows, the {NativeModule::committed_code_space_} counter can underflow because
    of a bug. This propagates to {WasmCodeManager::remaining_uncommitted_code_space_},
    which can lead to over-allocation (more than {kMaxWasmCodeMemory} bytes of code
    space per module).
    
    We were also seeing this bug on UMA data (>1024 MB code space usage).
    
    R=ahaas@chromium.org
    
    Bug: chromium:893096
    
    Change-Id: If3c9b3e7bdc9fc3caf1eccae991123409718b90f
    Reviewed-on: https://chromium-review.googlesource.com/c/1267943Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56440}
    eeb15e84
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...