• Clemens Backes's avatar
    [wasm] Fix stepping from a non-breakable position · 10dbddd1
    Clemens Backes authored
    ... at function start. Otherwise we run into a position mismatch:
    In a non-flooded function, we add the function-entry breakpoint (for
    "hook on function call") with the position of the first opcode.
    In the flooded function though, we skip that special breakpoint because
    we will stop at the first instruction anyway. But then the first
    instruction is non-breakable, so we don't actually emit a breakpoint for
    it.
    Hence during OSR we do not find a corresponding position in the new
    code.
    
    This CL fixes this by postponing the function-entry breakpoint until the
    first breakable opcode is found, and only emits it if that position does
    not have a breakpoint anyway.
    This way, we can also move the handling for function-entry breakpoints
    from {StartFunctionBody} to {EmitDebuggingInfo}, where it fits much
    better.
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1137710
    Change-Id: Idfa658fa0897cca89ba5ee3066cd414f68864d06
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474774Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70529}
    10dbddd1
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...