• Michael Lippautz's avatar
    cppgc-js: Support eager traced value in ephemeron pairs · ee3016b7
    Michael Lippautz authored
    Before this patch, both key and value of an ephemeron pair was always
    considered to be GarbageCollected objects.
    
    This patch adjusts the snapshotting mechanism to accomodate that
    values may not be GarbageCollected objects and must thus be eagerly
    traced for visibility and edge creation.
    
    In practice this only shows up in Blink when associating an existing
    wrappable with a wrapper in a non-main world, e.g., through an
    extension. In this case, DOMWrapperMap keeps the wrapper value through
    a TracedReference in the ephemeron map with the existing wrappable as
    key. The semantics are intended to be general ephemeron semantics,
    i.e., value needs to be kept alive when the key is alive.  This is
    visualized in DevTools as the main wrapper/wrappable pair (which is
    merged into a single node for the snapshot) retaining the non-main
    world wrapper.
    
    Bug: chromium:1245894
    Change-Id: Ibfa6722f20c76f94c310f9a040f0d3d4b9083bbb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3140601Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76658}
    ee3016b7
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...