• Dominik Inführ's avatar
    [heap] Immediately update external memory on JSArrayBuffer::Detach · edd27c77
    Dominik Inführ authored
    This CL changes the accounting of array buffers, such that Detach
    deducts the backing store immediately. Previously this was corrected
    in the next GC cycle.
    
    Not updating backing_store_bytes_ immediately could cause an overflow
    in WasmMemoryObject::Grow. Grow first detaches the backing store from
    the old JSArrayBuffer and then attaches it to a new one. This results
    in the backing store being accounted twice temporarily, this could cause
    overflows on 32-bit systems.
    
    Bug: chromium:1204455
    Change-Id: I7cf2ca9a12bb5caf7bcffa25a34567774cf155b8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871458
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74429}
    edd27c77
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...