• Benedikt Meurer's avatar
    [inspector] Introduce v8::StackFrame::GetLocation() API. · ed7b6640
    Benedikt Meurer authored
    This introduces a new `GetLocation()` method for `v8::StackFrame`s,
    which returns both line and column number at the same time (using the
    existing `v8::Location` class). Since `v8::StackFrame` instances store
    only the source position (per https://bit.ly/v8-stack-frame), we
    currently need to look up the source position in the Script's line table
    twice, once when we request the line number, and another time when we
    request the column number.
    
    With `GetLocation()` we perform only a single lookup in the Script's
    line table and return both line and column number at the same time. This
    cuts roughly 8% of the average execution time from the `standalone.js`
    benchmark mentioned in crbug.com/1280519.
    
    Bug: chromium:1280519, chromium:1278650, chromium:1069425
    Bug: chromium:1077657, chromium:1283162
    Doc: https://bit.ly/v8-cheaper-inspector-stack-traces
    Change-Id: Ia3a0502990b6230363112a358b59875283399404
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359628Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78452}
    ed7b6640
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...