• Clemens Backes's avatar
    [wasm] Replace RecursiveMutex by Mutex · eb7a36be
    Clemens Backes authored
    Some of the methods in {WasmCodeAllocator} can be called either without
    holding the lock, or while already holding it. In order to support both
    situations, we used a {RecursiveMutex} so far.
    This CL refactors this to be a simple {Mutex} again, and passes a
    {WasmCodeAllocator::OptionalLock} object which stores whether the lock
    is already held or not.
    Note that getting the lock twice fails immediately in debug builds,
    while forgetting to get the lock might only fail on TSan.
    
    The alternative would be to duplicate all methods, having one variant
    that expects that the lock is held and one that assume that it's
    unlocked. It would be multiple methods though to duplicate across both
    {NativeModule} and {WasmCodeAllocator}, hence I went for the
    {OptionalLock} instead.
    
    Bug: v8:9477
    
    R=mstarzinger@chromium.org
    
    Change-Id: I4e32286cdb93385ac655d408191b330efdd7ad66
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1825338
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64137}
    eb7a36be
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...