• adamk's avatar
    Fix FuncNameInferrer usage in ParseAssignmentExpression · eb67f854
    adamk authored
    Without this fix, AssignmentExpressions that happen to be arrow functions
    would lead to unbalanced Enter/Leave calls on the fni_, causing thrashing
    while trying to infer function names. Symptoms include slow parsing
    or OOM (when we create too many AstConsStrings).
    
    To try to keep this from happening in the future, added an RAII helper
    class to handle Entering/Leaving FNI state.
    
    The included regression test crashes on my workstation without the patch.
    Note that it's too slow in debug mode (as well as under TurboFan),
    so I've skipped it there.
    
    BUG=v8:4595
    LOG=y
    
    Review URL: https://codereview.chromium.org/1507283003
    
    Cr-Commit-Position: refs/heads/master@{#32768}
    eb67f854
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...