• Clemens Hammacher's avatar
    Revert "[wasm] Decouple background compile jobs from NativeModule" · ea513ab8
    Clemens Hammacher authored
    This reverts commit 92d9b09c.
    
    Reason for revert: Crashes on several bots, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20UBSan/4237
    
    Original change's description:
    > [wasm] Decouple background compile jobs from NativeModule
    > 
    > Background compile jobs should not keep the NativeModule alive, for two
    > reasons:
    > 1) We sometimes have to wait for background compilation to finish (from
    >    a foreground task!). This introduces unnecessary latency.
    > 2) Giving the background compile tasks shared ownership of the
    >    NativeModule causes the NativeModule (and the CompilationState) to
    >    be freed from background tasks, which is error-prone (see
    >    https://crrev.com/c/1400420).
    > 
    > Instead, this CL introduces a BackgroundCompileToken which is held
    > alive by the NativeModule and all background compile jobs. The initial
    > and the final phase of compilation (getting and submitting work)
    > synchronize on this token to check and ensure that the NativeModule is
    > and stays alive. During compilation itself, the mutex is released, such
    > that the NativeModule can die.
    > The destructor of the NativeModule cancels the BackgroundCompileToken.
    > Immediately afterwards, the NativeModule and the CompilationState can
    > die.
    > 
    > This change allows to remove two hacks introduced previously: The atomic
    > {aborted_} flag and the {FreeCallbacksTask}.
    > 
    > R=​mstarzinger@chromium.org
    > CC=​titzer@chromium.org
    > 
    > Bug: v8:8689, v8:7921
    > Change-Id: I42e06eab3c944b0988286f2ce18e3c294535dfb6
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel
    > Reviewed-on: https://chromium-review.googlesource.com/c/1421364
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59020}
    
    TBR=mstarzinger@chromium.org,clemensh@chromium.org
    
    Change-Id: I724f460f5aa654a9e75d3ce73d351214e69e2d96
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8689, v8:7921
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel
    Reviewed-on: https://chromium-review.googlesource.com/c/1429861Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59022}
    ea513ab8
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...