• Benedikt Meurer's avatar
    [inspector] Derive breakpoint hint based on resolved location. · ea3ee6da
    Benedikt Meurer authored
    When setting a breakpoint on a line (in the DevTools front-end), the
    front-end sends a columnNumber of 0 and the inspector automatically
    resolves the actual location (in bytecode execution order). In order
    to also support changing source code, the inspector memorizes a text
    hint, and uses that to adjust the location upon reload. This hint was
    however taken based on the original line and column numbers, rather than
    the resolved location, which causes trouble when syntactic order doesn't
    match execution order, as in case of `await o.m()`.
    
    In order to address that we now remember the textual hint based on the
    resolved location.
    
    Fixed: chromium:1081162
    Also-By: kimanh@chromium.org
    Change-Id: I7d08373440693b7abc18c29c1a05929d771d3031
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905606
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74675}
    ea3ee6da
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...