• Maya Lekova's avatar
    Revert "Get BytecodeArray via current frame where possible." · ea27a244
    Maya Lekova authored
    This reverts commit 7350e7b2.
    
    Reason for revert: Braking layout test, blocking the roll, see
    https://bugs.chromium.org/p/v8/issues/detail?id=8405
    
    Original change's description:
    > Get BytecodeArray via current frame where possible.
    > 
    > With BytecodeArray flushing the SFI->BytecodeArray pointer will become pseudo weak.
    > Instead of getting the bytecode array from the SFI, get it from the frame instead
    > (which is a strong pointer). Note: This won't actually change behaviour since the
    > fact that the bytecode array was on the frame will retain it strongly, however it
    > makes the contract that the BytecodeArray must exist at these points more explicit.
    > 
    > Updates code in runtime-profiler.cc, frames.cc and runtime-test.cc to do this.
    > 
    > BUG=v8:8395
    > 
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
    > Change-Id: Id7a3e6857abd0e89bf238e9b0b01de4461df54e1
    > Reviewed-on: https://chromium-review.googlesource.com/c/1310193
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Mythri Alle <mythria@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#57198}
    
    TBR=rmcilroy@chromium.org,mythria@chromium.org
    
    Change-Id: Ie5db0ec1d68ca01d62e9880a4476704ad4d013b5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8395
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/c/1314330Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57205}
    ea27a244
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...