• Daniel Clark's avatar
    Plumb import assertions through SourceTextModuleDescriptor's ModuleRequestMap · ea0ccc7e
    Daniel Clark authored
    This change plumbs import assertions from SourceTextModuleDescriptor's
    ModuleRequestMap into SourceTextModuleInfo via a new ModuleRequest
    type, where previously there had been only the specifier.
    
    SourceTextModuleDescriptor::module_map now deduplicates module requests
    using the specifier and the import assertions.  Continuing to use the
    specifier alone would cause a loss of information in the event that
    a module imports from the same specifier multiple times using different
    sets of assertions.  Failing to deduplicate at all would result in
    multiple requests for statements like `import {a,b,c} from "foo.js"`,
    which would be a potential performance issue.  See design doc at
    https://docs.google.com/document/d/1yuXgNHSbTAPubT1Mg0JXp5uTrfirkvO1g5cHHCe-LmY
    for more detail on this decision.
    
    v8::internal::ModuleRequest holds the assertions as an array of the form
    [key1, value1, position1, key2, value2, assertion2, ...].  However the
    parser still needs to use a map, since duplicate assertion keys need to
    be detected at parse time.  A follow-up  change will ensure that
    assertions are sorted using a proper lexicographic sort.
    
    Bug: v8:10958
    Change-Id: Iff13fb9a37d58fc1622cd3cce78925ad2b7a14bb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2493060
    Commit-Queue: Dan Clark <daniec@microsoft.com>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71066}
    ea0ccc7e
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...