• Marja Hölttä's avatar
    [parser] Minor refactoring: parameter handling · e7ebb930
    Marja Hölttä authored
    - Different places used is_simple to mean different things; renamed one.
    
    - No need to do Scope::SetHasNoSimpleParameters multiple times.
    
    - Normally we create VAR parameters with a name, or (for destructuring
      parameters), TEMPORARY parmeters with an empty name. *Except* for
      destructuring rest parameters; then we create VAR a parameter with an empty
      name. This CL makes the empty-named parameter TEMPORARY instead of VAR.
    
    - This makes it clear that Parser::DeclareFormalParameters declares exactly
      those params which Parser::BuildParamerterInitializationBlock doesn't declare.
    
    - This unification doesn't change any functionality, but it makes sense to do
      since I'll need to make PreParser emulate what Parser does; this way I don't
      need to emulate the weird behavior.
    
    BUG=v8:5501
    
    Change-Id: Ifa6c116bc5908f4e03a36e74f47558888d1582bd
    Reviewed-on: https://chromium-review.googlesource.com/443106Reviewed-by: 's avatarDaniel Vogelheim <vogelheim@chromium.org>
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#43220}
    e7ebb930
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...