• rdevlin.cronin's avatar
    Fix String16's move constructor · e6e968d0
    rdevlin.cronin authored
    String16 had a pseudo move constructor that took a const String16&&. The
    problem with this is that the point of moving objects is the ability to
    clobber the underlying data. If we look at this particular case, the
    move ctor tried to then std::move the underlying std::basic_string<>;
    this results in passing a const std::basic_string<>&& to the
    basic_string ctor. This resolves to the const std::basic_string<>&
    *copy* ctor. So in the end, we haven't moved anything.
    
    Fix this by taking a mutable rvalue reference that allows the moving to
    work as expected.
    
    BUG=None
    
    Review-Url: https://codereview.chromium.org/2616973002
    Cr-Commit-Position: refs/heads/master@{#42147}
    e6e968d0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...