• Etienne Pierre-doray's avatar
    [wasm] Avoid lock in BackgroundCompileToken · e6b2d673
    Etienne Pierre-doray authored
    Most code protected by compilation_scope_mutex_ is already either thread
    safe, or could run in parallel. Removing lock reduces contention.
    Note that weak_ptr::lock is atomic and thus still prevents deletion
    of NativeModule&CompilationStateImpl for the scope of
    BackgroundCompileScope.
    Related changes:
    - BackgroundCompileToken is deleted and publish_queue is moved to
      CompilationStateImpl.
    - Some of the (non thread-safe) logic in publish_results is moved into
      PublishCompilationResults so that it is serialized to 1 thread
      running publisher.
    - cancellation is handled by an atomic bool and is no longer
      synchronized. This means that compilation may be cancelled while
      a worker thread is still running. That thread would only
      stop once it reaches a new BackgroundCompileScope.
    
    Change-Id: I9651e924857c583d1a0fe5b9ffa99bfd01a8bda4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2442192Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70574}
    e6b2d673
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...