• Leszek Swirski's avatar
    [offthread] Add OffThreadFactory · e659917a
    Leszek Swirski authored
    Introduce OffThreadFactory with initial string construction support.
    
    The OffThreadFactory shares with Factory a new CRTP base class, called
    FactoryBase. Methods in FactoryBase return a FactoryHandle<Factory, T>
    alias, which is Handle<T> for normal Factory and a new OffThreadHandle<T>
    for OffThreadFactory. OffThreadHandle<T> behaves like Handle<T>, except
    it stores the object in-line rather than needing external storage.
    
    Any shared factory methods are moved into FactoryBase, which uses CRTP
    to call the sub-class's AllocateRaw method (plus a few more customization
    points which need Isolate access on the main thread).
    
    Methods that used to take an Isolate or Factory, and are needed off the
    main thread, are now expected to be templated on the factory type and
    to use the appropriate handle.
    
    Once an OffThreadFactory has finished being used (e.g. off-thread
    compilation completed) its pages are "Published" into the main-thread
    Heap. To deal with string internalization without creating a bunch of
    ThinStrings, this is done in two stages:
    
      1. 'FinishOffThread': The off-thread pages are walked to
         collect all slots pointing to "internalized" strings. After this is
         called it is invalid to allocate any more objects with the factory.
      2. 'Publish': On the main thread, we transform these slots into
         <Handle to holder, offset> pairs, then for each saved slot
         re-internalize its string and update the slot to point to the
         internalized string.
    
    Bug: chromium:1011762
    Change-Id: I008a694da3c357de34362bd86fe7e1f46b535d5e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1992434
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65787}
    e659917a
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...