• Benedikt Meurer's avatar
    [inspector] Cache StackFrames by script, line and column number. · e60dc99e
    Benedikt Meurer authored
    This introduces a stack frame cache on the V8Debugger level, which
    de-duplicates StackFrame instances based on their scriptId, line and
    column number.
    
    This greatly reduces the memory pressure when debugging huge Web
    applications that have a lot of async activity (and potentially
    have scripts with huge URLs). This is guided by the observation
    that even in huge applications, there are only a very limited
    number of call sites that initiate async activity and hence we
    only have a limited number of distinct StackFrames to worry
    about (despite having to maintain a large number of async stack
    traces overall).
    
    As a nice side effect, this CL also greatly reduces the negative
    performance impact of collecting async stack traces in these
    huge applications.
    
    Generally speaking this is mostly duct tape however, and we might
    want to follow up with changes to make capturing (and storing)
    stack frames even cheaper.
    
    Fixed: chromium:1268436
    Change-Id: Ib212b3c97dce2bb7ca47d5875d45cf20b9b97afe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272577
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77835}
    e60dc99e
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...