• Andreas Haas's avatar
    Add a not-NaN DCHECK to the Float32 constructor · e605a14e
    Andreas Haas authored
    The class Float32 stores the bit pattern of a float as uint32_t to
    guarantee that the exact bit pattern of the contained value is
    preserved. This is necessary because the bit pattern of a NaN may
    change, e.g. when it is passed as a parameter.
    
    For convenience the Float32 class provides a constructor with a float
    parameter. Since this constructor cannot guarantee that the right bit
    pattern will be stored for NaNs, this CL adds a DCHECK now to make
    sure that the constructor is never used with a NaN.
    
    R=mstarzinger@chromium.org
    
    Change-Id: Iba85a5a1bb2778d5f8bdc1aad97524ef8369b73d
    Reviewed-on: https://chromium-review.googlesource.com/579367
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46811}
    e605a14e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...