• Leszek Swirski's avatar
    [ignition] Always write the deferred command result register · e5df5bd0
    Leszek Swirski authored
    For deferred commands (such as in try-finally), some deferred commands
    save and restore the accumulator using a result register (e.g. return,
    throw, rethrow), while others don't (e.g. break, continue,
    fall-through).
    
    However, conditionally reading this result register that may not ever be
    written caused it to be considered live from the start of the function,
    as far as the liveness analysis could statically tell.
    
    Now, we write the result register for all deferred commands, including
    the fall-through. As a micro-optimization, we re-use the Smi command
    tokeen to clobber the result, rather than emitting an LdaUndefined.
    
    Bug: chromium:758472
    Change-Id: I2ea65e2249b40ee6403216e654a8bb88d50bec3b
    Reviewed-on: https://chromium-review.googlesource.com/635592
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47612}
    e5df5bd0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...