• Andreas Haas's avatar
    [turbofan] Don't assume that Word32AtomicPairLoad has a projection-0 · e56a7edb
    Andreas Haas authored
    The instruction selector assumed for Word32AtomicPairLoad node that if
    there exists a Projection(1) user, then there also exists a
    Projection(0) user. This, however, is not the case, because TurboFan
    eliminates unreachable nodes. The missing projection node lead to a
    failed DCHECK in the register allocator.
    
    To fix the problem I use now the Word32AtomicPairLoad node directly to
    allocate the register. On ia32 I stop additionally to allocate unneeded
    temp registers.
    
    R=gdeepti@chromium.org
    CC=zhin@chromium.org
    
    Bug: chromium:1042379
    Change-Id: I79bd9f3f4672e147246a71c32b7c9b4dbd79b17f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002547
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65912}
    e56a7edb
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...