• littledan's avatar
    Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of... · e549c7a3
    littledan authored
    Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of https://codereview.chromium.org/1554523002/ )
    
    Reason for revert:
    Should be fixed again with this Blink change to add NeedsManualRebaseline
    
    Original issue's description:
    > Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ )
    >
    > Reason for revert:
    > [Sheriff] Changes layout tests. Please fix upstream first if intended.
    >
    > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689
    >
    > Original issue's description:
    > > Use ES2015-style TypedArray prototype chain
    > >
    > > This patch switches TypedArrays to use the prototype chain described
    > > in the ES2015 specification, which adds a %TypedArray% superclass above
    > > all individual TypedArray types. Most methods are defined on the
    > > superclass rather than the subclasses.
    > >
    > > In order to prevent a performance regression, a few methods are
    > > marked as inline. Inlining might prevent code which was previously
    > > monomorphic from becoming polymorphic, and it was specifically
    > > applied in places where methods became more polymorphic than before.
    > > Tests with realistic workloads would be nice to do before this
    > > ships in stable.
    > >
    > > This patch does not bring TypedArrays up to full spec compliance. In
    > > particular, @@species is not yet supported.
    > >
    > > R=cbruni
    > > BUG=v8:4085
    > > LOG=Y
    > >
    > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7
    > > Cr-Commit-Position: refs/heads/master@{#33050}
    >
    > TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org
    > NOPRESUBMIT=true
    > NOTREECHECKS=true
    > NOTRY=true
    > BUG=v8:4085
    >
    > Committed: https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c
    > Cr-Commit-Position: refs/heads/master@{#33053}
    
    TBR=caitpotter88@gmail.com,cbruni@chromium.org,machenbach@chromium.org
    BUG=v8:4085
    LOG=Y
    
    CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
    
    Review URL: https://codereview.chromium.org/1558663002
    
    Cr-Commit-Position: refs/heads/master@{#33067}
    e549c7a3
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...