• Benedikt Meurer's avatar
    [objects] No longer create short external strings. · e42e7fc8
    Benedikt Meurer authored
    This fixes String::MakeExternal() to bail out if the subject string
    doesn't fit a regular ExternalString, instead of creating a short
    external string. The observation here is that for short external strings
    the overhead of having to have the StringResource plus going to the
    runtime/C++ for each and every character access from JavaScript land
    is probably bigger than the anticipated benefits.
    
    If this turns out to be wrong and there's a real benefit, we should make
    use of ThinStrings instead of having a separate way to represent
    external strings.
    
    Bug: v8:6621, v8:7109, v8:7145
    Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d
    Reviewed-on: https://chromium-review.googlesource.com/799750Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49735}
    e42e7fc8
Name
Last commit
Last update
..
dead-code-source-position.js Loading commit data...
dynamic-global-inside-block.js Loading commit data...
ignition-statistics-extension.js Loading commit data...
optimized-stack-trace.js Loading commit data...
osr-from-bytecode.js Loading commit data...
osr-from-generator.js Loading commit data...
print-ast.js Loading commit data...
regress-597565-double-to-object-transition.js Loading commit data...
regress-599001-verifyheap.js Loading commit data...
regress-612386-smi-to-double-transition.js Loading commit data...
regress-616064.js Loading commit data...
regress-629792-source-position-on-jump.js Loading commit data...
regress-662418.js Loading commit data...
regress-664146.js Loading commit data...
regress-672027.js Loading commit data...
stack-trace-source-position.js Loading commit data...
string-concat-external-thin-string.js Loading commit data...
throw-if-hole.js Loading commit data...
throw-if-not-hole.js Loading commit data...
throw-super-not-called.js Loading commit data...
tracing.js Loading commit data...