• jgruber's avatar
    [coverage] Fix invalid coverage block transformation · e42ce200
    jgruber authored
    Before reporting coverage data, we attempt to reduce clutter by
    merging nested and consecutive ranges. Nested ranges are merged, if
    the child range has the same execution count as the parent range.
    Sibling ranges are merged, if one sibling begins where the other ends
    and execution counts are identical.
    
    This allowed an invalid transformation in which a range with an
    execution count of 1 would be merged into the parent change, but the
    sibling range with identical start and end points and a count of 0
    would remain, effectively deleting the covered range.
    
    For example:
    
    {start: 0, end: 10, count: 1},
    {start: 5, end:  8, count: 1},  // It's invalid to remove this.
    {start: 5, end:  8, count: 0}
    
    The fix is to separate the parent and sibling merge passes, and
    removing duplicate ranges in-between.
    
    Bug: chromium:827530
    Change-Id: Ic35eae1d4a106746570ce9cb412ed6710ef6da53
    Reviewed-on: https://chromium-review.googlesource.com/992114Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52352}
    e42ce200
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...