• Simon Zünd's avatar
    [debug] Report variables in TDZ as 'value unavailable' · e417b339
    Simon Zünd authored
    Consider the function:
    
    function foo() {
      debugger;
      let y = 1;
    }
    
    V8 will elide the hole initialization for 'y'. When we pause at the
    debugger statement, then 'y' evaluates to 'undefined'.
    
    This CL fixes this in the ScopeIterator. When we encounter local
    variables with an `undefined` value we check the static scope
    information if we are stopped *before* the variable's initializer.
    If yes, then we are in the variable's TDZ and report
    "value unavailable".
    
    Drive-by: Mark `GetSourcePosition()` as `const` to make it available
    in the visitor method.
    
    R=bmeurer@chromium.org
    
    Bug: chromium:1328681
    Change-Id: I8b966eaa2af64a35a58095a744440851760921a0
    Fixed: chromium:1303493
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829539
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82483}
    e417b339
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...