• Shu-yu Guo's avatar
    Revert "Refactor dynamic name to perfetto::DynamicString" · e4167a68
    Shu-yu Guo authored
    This reverts commit c801d529.
    
    Reason for revert: Broke perfetto builder:
    https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20debug%20-%20perfetto%20-%20builder/19620/overview
    
    Original change's description:
    > Refactor dynamic name to perfetto::DynamicString
    >
    > Recently perfetto introduced `perfetto::DynamicString` to allow clients
    > to wrap dynamic event name strings. So that clients don't have to
    > manually set event name inside trace lambda.
    >
    > With that:
    >
    > TRACE_EVENT("cat", nullptr, [&](EventContext ctx) {
    >   ctx.event().set_name(dynamic_name_str)
    > });
    >
    > is simplified to:
    >
    > TRACE_EVENT("cat", perfetto::DynamicString{dynamic_name_str});
    >
    > In this change we are making use of perfetto::DynamicString to pass
    > dynamic event name string.
    >
    > Change-Id: Ic6b501df67409d6faa4d60b59095ad0e79ce585e
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716473
    > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
    > Commit-Queue: Mohit Saini <mohitms@google.com>
    > Cr-Commit-Position: refs/heads/main@{#81298}
    
    Change-Id: I06d1d6baa4413e53acfd7ac1e3163c5a6a15597c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3718436
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#81312}
    e4167a68
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...