• Michael Lippautz's avatar
    [heap] Remove DCHECKs when clearning on-stack handles · e3b27b4a
    Michael Lippautz authored
    The DCHECKs ensured that all on-stack handles removed when the embedder
    notifies V8 of an empty stack are indeed below the current stack limit.
    
    This is brittle, as the calls that are guaranteed to have no stack
    above, e.g., non-nestable tasks executing GC, sometimes have larger
    stack depth then previously registered on-stack handles. Resetting the
    slot to avoid UAF is not possible/needed as it is guaranteed in such
    cases that the stack is indeed different from the stack that was used
    when registering an on-stack handle.
    
    This CL removes the DCHECKs and trust the embedder on such calls,
    similar to when the embedder tells V8 that there's no interesting C++
    stack on top of a call to avoid conservative stack scanning.
    
    Bug: chromium:1040038
    Change-Id: I2e8c77d8080f2d888f773984646998bede59e19c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2000753Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65786}
    e3b27b4a
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...