• Leszek Swirski's avatar
    [modules] Make exported variable indices stable · e39b90f6
    Leszek Swirski authored
    A module's exported variables are assigned a cell index based on their
    order in the exported variable map. This map is keyed by the variable
    name, an AstRawString*.
    
    Unfortunately, these string pointers are not guaranteed to increase
    monotonically as variables are encountered, which means that this map
    isn't stable across parses. In particular, it can cause failures for
    setVariableValue if the parser is unlucky.
    
    This patch adds a custom comparator to these AstRawString* keyed maps,
    which is stable across parses.
    
    Change-Id: Ie6e88fc2d252d873de661d7fc5278feba3955727
    Reviewed-on: https://chromium-review.googlesource.com/1131503Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54379}
    e39b90f6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...