• Simon Zünd's avatar
    [array] Remove CHECK_LE from RemoveArrayHolesGeneric · e38faab1
    Simon Zünd authored
    This CL removes a CHECK_LE that does not hold in all cases. After
    moving all elements to the front, current_pos will point to the next
    free spot. In the case where an object is 'packed', i.e. each index
    has a non-undefined value, and the length is smaller then the max
    index, current_pos will be greater than the length (limit in the code).
    
    Sidenote: The block after taking the minimum (where the counted
    undefineds get set) will not be affected. In the case where
    num_undefined > 0, current_pos should be guaranteed to be smaller
    than limit, as long there are no accessors with side-effects.
    
    R=jgruber@chromium.org
    
    Bug: chromium:923265
    Change-Id: Id533cdc4db6c6c6f266cf7c6a8ab6ecbbeee7016
    Reviewed-on: https://chromium-review.googlesource.com/c/1420679Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58912}
    e38faab1
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...