• Milad Fa's avatar
    PPC: Use native x64 linux page size on the simulator · e35a3a77
    Milad Fa authored
    Running `OS::AllocatePageSize()` on PPC simulator (which
    runs on x64 Linux) will make a `sysconf(_SC_PAGESIZE)` call
    which returns the native x64 Linux page size and not the PPC
    specific page size.
    
    This can cause a problem if used along side the current value of
    `kPageSizeBits` which is set to use PPC value even on Sim.
    As an example a newly added DHCECK under https://crrev.com/c/3497363
    was failing on PPC Sim as a call to `AllocatableMemoryInDataPage`
    was being made which used kPageSizeBits on Sim.
    
    Meanwhile another function was using the `page_size_bits` value which
    gets set by _SC_PAGESIZE. The mismatch caused an incorrect final value
    being generated which failed the DCHECK.
    
    Change-Id: Iaf2d9cff16bbe5f6be5f3ec6a13b99be94776f48
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3519758Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#79465}
    e35a3a77
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...