• Georg Neis's avatar
    [turbofan] Don't verify context input of Create*Context nodes · e33d6338
    Georg Neis authored
    The verifier tried to assert that the context input of Create*Context
    nodes has type OtherInternal (all Context constants have that type).
    This didn't quite work because of OSR values so actually it checked
    something much weaker. And what it checked still doesn't work because
    of dead code, in which the context input might statically be known to
    be the undefined value. I'm removing the assertion entirely now.
    
    I suspect that there are other assertions in the verifier that don't
    hold in the OSR code or in dead code. We are discussing a more general
    solution such as inserting TypeGuards in the relevant cases.
    
    Bug: chromium:1037771
    Change-Id: I6fb59c60e7120d5984ea0fe140269f2df6de8708
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2010792
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Auto-Submit: Georg Neis <neis@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65871}
    e33d6338
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...