• Clemens Hammacher's avatar
    [wasm] Refactor and fix ErrorThrower · e3207836
    Clemens Hammacher authored
    The error thrower did allocate the exception at the moment the error was
    detected. For async compilation, this meant in another step than when
    it was actually thrown. Since the HandleScope of the exception already
    died at that point, this would have lead to memory errors.
    
    With this refactoring, we only store the information needed to generate
    the exception in the ErrorThrower, and only generate the exception
    object once it is actually needed.
    
    With regression test.
    
    R=ahaas@chromium.org, mtrofin@chromium.org
    Also-by: ahaas@chromium.org
    
    Change-Id: Iffcab1f8d1cf5925e3643fcf0729ba9a84c7d277
    Reviewed-on: https://chromium-review.googlesource.com/490085
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45000}
    e3207836
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...